Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent database rebuild when server starting #269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bjmmartin
Copy link

While using the emulator, we encounter the same error as #207.

After looking a bit at the code, I found that when the server is starting, we try to reinsert all data, that are already in the database.

The proposal here is to rebuild the project only when the --data-from-yaml is provided.
So if we found a project, and we are just loading from the database, we stop here, but if we load with the option it removes the project and its jobs and dataset, and rebuild it from scratch.

I don't know all cases, so it might break some edge case, maybe it could be an option to the command.

Let me know if some changes are required. And thanks a lot for the project 🙏

@chrisK824
Copy link

Hey there @totem3 , have you seen this maybe? Is there a timeline estimate for this fix, if any?

Thanks im advance!

@chrisK824
Copy link

Hi @goccy , this one seems pretty useful to stay parked, do you agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants