Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data is not appended with committed streams #267

Merged

Conversation

tomrussello
Copy link
Contributor

With the Big Query Storage API, when using a committed stream, I had the same issue as #247. Looking at the code, it seems that no commit was done to the transaction

@totem3
Copy link
Collaborator

totem3 commented Feb 5, 2024

Thank you for your pull request.
We would like to have automated tests to verify that this fix actually solves the issue.
I have written a test for this PR here (tomrussello#1).

@goccy, I have confirmed with the above test that this Pull Request actually fixes the issue.
It has been verified that data in Pending Streams does not become valid until the stream is Finalized and Committed, and in Committed Streams, the data becomes valid automatically with each write.

If possible, I would appreciate it if you could review the PR (including tests in tomrussello#1).
If it's better to bundle the test and this fix together into a single Pull Request for this repository, please let me know.

@tomrussello
Copy link
Contributor Author

Thank you @totem3 for adding the testing part and confirming the fix.

Waiting for @goccy's input before merging anything in my branch

@goccy
Copy link
Owner

goccy commented Feb 6, 2024

@totem3 OK, Thank you for testing this.
@tomrussello Please let me know when the test code is added and I will merge this.

…-streams

Added test for Committed Stream
@tomrussello
Copy link
Contributor Author

@goccy code is added to my branch

@goccy
Copy link
Owner

goccy commented Feb 6, 2024

Thank you for your contribution !! LGTM 👍

@goccy goccy merged commit 646ec96 into goccy:main Feb 6, 2024
4 checks passed
@tomrussello
Copy link
Contributor Author

@goccy Do you know when a new release will be created, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants