App Submission: GitLab #443
nmfretzAnnotations
2 warnings and 1 notice
|
Invalid restart policy:
gitlab/docker-compose.yml#L13
The restart policy of the container "gitlab" should be set to "on-failure".
|
|
"icon" and "gallery" needs to be empty for new app submissions:
gitlab/umbrel-app.yml#L53
The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.
|
|
External port mapping "2424:22":
gitlab/docker-compose.yml#L28
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
|