Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Submission: GitLab #1290

Merged
merged 5 commits into from
Sep 18, 2024
Merged

App Submission: GitLab #1290

merged 5 commits into from
Sep 18, 2024

Conversation

hugofnm
Copy link
Contributor

@hugofnm hugofnm commented Jul 31, 2024

App Submission

App name

GitLab Community Edition

256x256 SVG icon

(Submit an icon with no rounded corners as it will be dynamically rounded with CSS. GitHub doesn't allow uploading SVGs directly, so please upload your icon to an alternate service, like https://svgur.com, and paste the link below.)
We will help finalize this icon before the app goes live in the Umbrel App Store.

https://images.ctfassets.net/xz1dnu24egyd/3JZABhkTjUT76LCIclV7sH/17a92be9bce78c2adcc43e23aabb7ca1/gitlab-logo-500.svg

Gallery images

(Upload 3 to 5 high-quality gallery images (1440x900px) of your app in PNG format, or just upload 3 to 5 screenshots of your app and we'll help you design the gallery images.)
We will help finalize these images before the app goes live in the Umbrel App Store.

Screenshot1
Screenshot2
Screenshot3

I have tested my app on:

  • umbrelOS on a Raspberry Pi
  • umbrelOS on an Umbrel Home
  • umbrelOS on Linux VM

Linked Issue : #1219

Copy link
Contributor

@sharknoon sharknoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome submission @hugofnm :) I'm looking forward seeing this a simple one-click install on umbrelOS :) I have left some suggestions below:

gitlab/umbrel-app.yml Outdated Show resolved Hide resolved
gitlab/umbrel-app.yml Outdated Show resolved Hide resolved
gitlab/umbrel-app.yml Outdated Show resolved Hide resolved
gitlab/umbrel-app.yml Outdated Show resolved Hide resolved
gitlab/umbrel-app.yml Outdated Show resolved Hide resolved
gitlab/umbrel-app.yml Outdated Show resolved Hide resolved
gitlab/umbrel-app.yml Outdated Show resolved Hide resolved
gitlab/docker-compose.yml Outdated Show resolved Hide resolved
gitlab/docker-compose.yml Show resolved Hide resolved
- Add app_proxy
- Change ports
- Update umbrel_app.yml
@sharknoon
Copy link
Contributor

@hugofnm Thank you for your edits. This submission looks awesome!
@nmfretz I think we are ready to go :)

@nmfretz
Copy link
Contributor

nmfretz commented Sep 5, 2024

Sorry for missing this ping @sharknoon @hugofnm! Will take a look at this today.

@nmfretz
Copy link
Contributor

nmfretz commented Sep 5, 2024

This is working really well. Fantastic work @hugofnm.

I have tested on arm64 and x86, including the flow of registering a new non-admin account and then approving the account as admin.

We'll get the gallery assets finalized and then send this to the app store!

@DavidGarciaCat
Copy link
Contributor

Wishing to get this App since it was me who created the issue requesting it 🤣

Do we have an ETA for it?

@nmfretz
Copy link
Contributor

nmfretz commented Sep 12, 2024

Ha, sorry for the delay @DavidGarciaCat! We're backlogged with some high-priority tasks on the design side, but we'll get the gallery assets done soon and get this to the app store 🤝

@getumbrel getumbrel deleted a comment from github-actions bot Sep 18, 2024
@nmfretz
Copy link
Contributor

nmfretz commented Sep 18, 2024

Thanks again for this wonderful submission @hugofnm! Gallery assets have been prepared and we are going live:

image

@nmfretz nmfretz merged commit ce53944 into getumbrel:master Sep 18, 2024
1 check passed
@DavidGarciaCat
Copy link
Contributor

Yay!! Time to install it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants