ref(uptime): Extract OpType, ComparisonType, and AssertionType enums#108551
Open
ref(uptime): Extract OpType, ComparisonType, and AssertionType enums#108551
Conversation
…ne string unions Replaces hardcoded string literals in AssertionSuggestion interface with shared enums for better reusability and type safety. Ref NEW-751
github-actions
bot
added
the
Scope: Frontend
Replaces hardcoded string literals throughout the uptime assertion types file and all consumers with shared enums for better reusability and type safety. - OpType: discriminant for Op tree nodes (and, or, not, status_code_check, json_path, header_check) - ComparisonType: comparison operators (equals, not_equal, less_than, greater_than, always, never) - AssertionType: Seer suggestion assertion categories (status_code, json_path, header) - Refactored Comparison type to use ComparisonType enum Ref NEW-751
….spec.tsx TypeScript widens enum members to the full enum type in object literals, breaking discriminated union narrowing. Use explicit type annotations instead of `as const` to preserve type safety without readonly conflicts. Also updates detectors/forms/uptime/fields.spec.tsx which was missed in the initial enum refactoring.
3 tasks
jaydgoss
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Seer suggestions never return 'never' as a comparison value, so exclude ComparisonType.NEVER from the AssertionSuggestion interface to avoid unintentional type widening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpType: discriminant for Op tree nodes (and,or,not,status_code_check,json_path,header_check)ComparisonType: comparison operators (equals,not_equal,less_than,greater_than,always,never)AssertionType: Seer suggestion assertion categories (status_code,json_path,header)Comparisontype to useComparisonTypeenumRef NEW-751
Test plan