ref(uptime): Prefix uptime assertion-related type exports with Uptime#108562
Open
jaydgoss wants to merge 1 commit intojaygoss/new-751-add-enums-for-assertion_type-and-comparison-in-uptimefrom
Conversation
github-actions
bot
added
the
Scope: Frontend
jaydgoss
changed the title
jaydgoss
changed the title
…ming collisions Renames all assertion-related type exports in the uptime types file to include an Uptime prefix (e.g. Op -> UptimeOp, Assertion -> UptimeAssertion, ComparisonType -> UptimeComparisonType). This prevents naming collisions when these types are imported elsewhere in the codebase.
jaydgoss
force-pushed
the
jaygoss/uptime-prefix-assertion-types
branch
from
fb15e35 to
d383674
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
types.tsxto include anUptimeprefix (e.g.Op->UptimeOp,Assertion->UptimeAssertion,ComparisonType->UptimeComparisonType)Test plan