-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix set site settings in swagger_ui so it function correctly. #8582
Merged
ianwallen
merged 1 commit into
geonetwork:main
from
ianwallen:fix_save_setting_swagger_ui
Jan 10, 2025
Merged
Fix set site settings in swagger_ui so it function correctly. #8582
ianwallen
merged 1 commit into
geonetwork:main
from
ianwallen:fix_save_setting_swagger_ui
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianwallen
force-pushed
the
fix_save_setting_swagger_ui
branch
from
December 24, 2024 19:04
37e2faf
to
adc73ff
Compare
Prior to this fix, the swagger ui for applying site settings was not working.
ianwallen
force-pushed
the
fix_save_setting_swagger_ui
branch
from
December 25, 2024 00:55
adc73ff
to
c9e0ae9
Compare
josegar74
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works fine. Code changes look good.
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.2.x 4.2.x
# Navigate to the new working tree
cd .worktrees/backport-4.2.x
# Create a new branch
git switch --create backport-8582-to-4.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick c9e0ae9bf2273ff80b6fc15e698c86c5ad355cf6
# Push it to GitHub
git push --set-upstream origin backport-8582-to-4.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.2.x Then, create a pull request where the |
tylerjmchugh
pushed a commit
to tylerjmchugh/core-geonetwork
that referenced
this pull request
Jan 10, 2025
…work#8582) Prior to this fix, the swagger ui for applying site settings was not working. (cherry picked from commit 21f0dc8)
ianwallen
added a commit
that referenced
this pull request
Jan 10, 2025
…#8589) Prior to this fix, the swagger ui for applying site settings was not working. (cherry picked from commit 21f0dc8) Co-authored-by: Ian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix, the swagger ui for applying site settings was not working.
Before the swagger ui would look like the following
And generate the following error
After, it will look like the following (with some examples.)
And when valid values are supplied, it will generate the following results
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation