Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filesystemStore bean instead of hardcoded class #8486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wangf1122
Copy link
Collaborator

The intention of this code change is to fix potential issue with harvesting file store. The current file store was hardcoded to FileSystemStore class instead of dynamic bean injection.

The similar fix was apply to this pull request which is already merged https://github.com/geonetwork/core-geonetwork/pull/8466/files

Store store = ApplicationContextHolder.get().getBean("filesystemStore", Store.class);

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@wangf1122 wangf1122 marked this pull request as ready for review November 6, 2024 01:32
@josegar74 josegar74 added this to the 4.4.7 milestone Nov 6, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants