updating biscuit version, adding flexbar and picard to container #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmooney
reviewed
Jan 27, 2021
|
Thanks for the feedback - fixes pushed and tested |
tmooney
approved these changes
Jan 28, 2021
| #Biscuit QC scripts# | ||
| #################### | ||
| RUN cd /opt && \ | ||
| git clone https://github.com/zwdzwd/biscuit.git |
There was a problem hiding this comment.
Should this point to a particular release or commit?
There was a problem hiding this comment.
That's complicated, because the latest release doesn't have some updates. Furthermore, the repo has been forked and this one isn't under active development anymore. In the next 6 months, we're going to have to grab the other version and update to the new QC tools, but that's a separate PR, so I'm going to leave this as-is for now. There's already an issue in to update these scripts at genome/analysis-workflows#993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.