Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade fgbio to 1.3.0 #978

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Upgrade fgbio to 1.3.0 #978

merged 1 commit into from
Dec 22, 2020

Conversation

tmooney
Copy link
Member

@tmooney tmooney commented Dec 14, 2020 •
edited
Loading

This switches away from our fat DNA alignment image to an fgbio image on biocontainers as well.

This is part of #948.

chrisamiller
chrisamiller approved these changes Dec 16, 2020
View reviewed changes
Copy link
Collaborator

@chrisamiller chrisamiller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 I confirm that the docker image exists, the path is correct for the commands, and that the clipping mode param matches up with the new setting (it's already Hard by default, but I'm all for being explicit!)

@tmooney tmooney merged commit 3a287b7 into genome:master Dec 22, 2020
@tmooney tmooney deleted the fgbio_130 branch December 22, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisamiller chrisamiller chrisamiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmooney @chrisamiller