Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoove to v0.2.6 #966

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Smoove to v0.2.6 #966

merged 2 commits into from
Nov 11, 2020

Conversation

apaul7
Copy link
Member

@apaul7 apaul7 commented Nov 10, 2020

This PR upgrades smoove to version 0.2.6. The previous version was 0.1.6. I decided to not use the sha256 for better readability on what version is being used in the CWL.

There are a lot of improvements in calling variants, speeding up analysis, and bug fixes.

The location of where smoove is installed has changed. The inputs/outputs are the same.
part of #948

Copy link
Collaborator

@chrisamiller chrisamiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

presumably brentp's repos are going to be subject to the docker pull limits. Should we consider using the quay version instead? https://quay.io/repository/biocontainers/smoove?tab=tags

@apaul7
Copy link
Member Author

apaul7 commented Nov 10, 2020

Good idea! I didn't even check for a quay image. I've updated the CWL to use the quay docker image.

Copy link
Member

@tmooney tmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 🦓

@apaul7 apaul7 merged commit 10870ae into genome:master Nov 11, 2020
@apaul7 apaul7 deleted the smoove-upgrade branch November 11, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants