Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the message generation framework #398

Closed
wants to merge 3 commits into from

Conversation

mjcarroll
Copy link
Contributor

This updates transport to use the message generation framework from gazebosim/gz-msgs#339

@mjcarroll mjcarroll requested a review from caguero as a code owner May 23, 2023 13:37
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 23, 2023
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. I guess we'll need to merge gz-msgs first and release it, that's why I won't approve yet.

@scpeters
Copy link
Member

This works for me. I guess we'll need to merge gz-msgs first and release it, that's why I won't approve yet.

we don't need to release this; we just need nightly builds

@scpeters
Copy link
Member

@osrf-jenkins run tests please

@scpeters
Copy link
Member

scpeters commented Jul 6, 2023

I found some other issues in gazebosim/gz-msgs#339 (comment), and I believe they are addressed by the following PRs:

Testing with specially-named branches:

Running protoc on C:/J/workspace/ign_transport-pr-win/ws/install/gz-msgs10//share/protos/gz/msgs/actor.proto

  --ignmsgs_out: protoc-gen-ignmsgs: The system cannot find the file specified.

  Failed to execute protoc compiler: Command
 '['C:/vcpkg/installed/x64-windows/tools/protobuf/protoc.exe',
 '--proto_path=C:/J/workspace/ign_transport-pr-win/ws/install/gz-msgs10//share/protos',
 '--plugin=protoc-gen-ignmsgs=C:/J/workspace/ign_transport-pr-win/ws/install/gz-msgs10//bin/gz-msgs10_protoc_plugin',
 '--cpp_out=C:/J/workspace/ign_transport-pr-win/ws/build/gz-transport13/gz_msgs_gen',
 '--ignmsgs_out=C:/J/workspace/ign_transport-pr-win/ws/build/gz-transport13/gz_msgs_gen',
 'C:/J/workspace/ign_transport-pr-win/ws/install/gz-msgs10/share/protos/gz/msgs/actor.proto']'
 returned non-zero exit status 1.

@scpeters
Copy link
Member

scpeters commented Jul 7, 2023

I built a jammy nightly of gz-msgs10 (see gazebo-release/gz-msgs10-release#3 (comment)) and ran the jammy jenkins build for this branch, and it also has some test failures:

@mjcarroll mjcarroll closed this Jul 26, 2023
@mjcarroll mjcarroll deleted the mjcarroll/rework-message-generation branch July 26, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants