-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds python interface to RollingMean, Color and Spline #218
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-math6 #218 +/- ##
==========================================
Coverage 99.22% 99.22%
==========================================
Files 66 66
Lines 6162 6162
==========================================
Hits 6114 6114
Misses 48 48 Continue to review full report at Codecov.
|
aaaa60a
to
895eb1e
Compare
General commentsGiven that there is no assignment in python the The The ColorIn C++ the getter methods are overloaded, so for example, getting the r element of a color could be done with both of this methods: |
@LolaSegura Please create another PR with the files related to |
71a152d
to
b03e678
Compare
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
…tyle. Signed-off-by: LolaSegura <[email protected]>
…hon test to the python folder. Signed-off-by: LolaSegura <[email protected]>
b03e678
to
c0407ad
Compare
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a few comments
src/python/RollingMean.i
Outdated
#endif | ||
}; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Add an extra empty line at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
Signed-off-by: LolaSegura <[email protected]>
Signed-off-by: LolaSegura <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@scpeters @chapulina It is ready for an extra review! |
I just resolved conflicts after merging #220 |
Signed-off-by: LolaSegura <[email protected]>
…tionrobotics/ign-math into LolaSegura/python_interface
🎉 New feature
Goes on top of #216.
Related to #101 #210
Summary
Adds
Python
interface for three math classes:RollingMean
,Color
,Spline
. For each class a python test has been created.Checklist
codecheck
passed (See contributing)