-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows installation instructions per library #117
Comments
For the record, we have internal docs up to It's safe to say this issue is blocked on the |
I do not know if I a missing something, but I think that opening a PR again the ignition-cmake repo containing the patch in https://github.com/conda-forge/libignition-cmake0-feedstock/blob/master/recipe/FindGTS.cmake.patch is a perfectly fine solution, and in general a correct bug fix for any system in which |
Regarding the list of tutorials, ign-cmake doesn't have such a page (because it's unreleased?), but ign-math depends on ign-cmake, right? Should we put the ign-cmake Windows instructions in https://github.com/ignitionrobotics/ign-cmake/blob/ign-cmake2/README.md ? Then ign-math's doesn't need to talk about ign-cmake. |
Ah nice catch, this is part of #53
Yeah let's put it in the README for now |
Actually I went ahead and added tutorial generation for |
Thanks! I targeted that page for ign-cmake. Should we duplicate the installation instructions to all the READMEs? That might get more visibility since that shows up on https://ignitionrobotics.org/libs/ . I can copy the text from the tutorials over to the READMEs for all the PRs once the texts are reviewed. ign-common also doesn't seem to have an installation tutorial, but does have a README, so we'd be duplicating the Ubuntu stuff from the README to a new installation tutorial. |
We did a good push deduplicating the install instructions on #14, but as you pointed out, we missed some libraries. I reopened it with a list of the libraries that are left. Maybe some of those can be tackled as the Windows tutorials are added? |
Nice. Yeah I can do that while I'm at it. |
I've opened PRs for everything other than ign-gazebo and ign-launch, as referenced in the list above. In order to have binary install instructions for everything, we need to add libignition-rendering, libignition-sensors, libignition-gui to conda-forge. These already compile on Windows. List of ignition libraries currently on conda-forge: https://github.com/conda-forge?q=libignition&type=&language= While I was at it, I tried to make the tutorials somewhat uniform, but there were a few that looked very minimalist that I didn't flesh out - ign-tools, ign-msgs, sdformat. They don't have prerequisites and binary install sections like others even for Ubuntu. It'd take more effort to write those. Should I target the release branch or |
Looks like the missing libraries are being tracked here conda-forge/staged-recipes#13551 |
Awesome, thanks @mabelzhang !
The Citadel branches would be ideal wherever possible, because that's the LTS. But don't worry if you've been targeting Dome, we can backport as needed. |
I checked all the available versions on conda-forge ( So I can retarget all the libraries with Conda feedstock to Citadel, and leave the ones without feedstock (ign-rendering, ign-sensors, ign-gui) targeted to Dome? Double-checking if that's what we want. This would be the result:
|
I think it would be nice to target them all at Citadel, and then we can forward-port everything to Dome where needed. That should lay the groundwork for the top-level tutorial (#126) to target Citadel. |
Okay cool will retarget all to Citadel then. These three in the list above will be modified to
|
Related to #96.
Lots of our libraries already build and run on Windows, but we don't have tutorials on how to do that yet.
Each library has their own install tutorial, and we should add this information there. Note that this is different from the top-level tutorials install tutorials that live in this repository (that's covered by #96).
These are the tutorials to be updated:
The text was updated successfully, but these errors were encountered: