-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows installation #161
Conversation
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui4 #161 +/- ##
=========================================
Coverage 61.57% 61.57%
=========================================
Files 21 21
Lines 2790 2790
=========================================
Hits 1718 1718
Misses 1072 1072 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small verbiage nit
1. Follow the [source install instruction](#source-install). | ||
|
||
2. Run tests. | ||
Before ``ign-rendering`` becomes available on conda-forge, we need to build it from source and specify the path containing ``ignition-rendering<#>-config.cmake`` and ``ignition-rendering<#>-ogre-config.cmake`` in ``CMAKE_PREFIX_PATH``. That path could be ``ign-rendering-install-path\lib\cmake``, for example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before ``ign-rendering`` becomes available on conda-forge, we need to build it from source and specify the path containing ``ignition-rendering<#>-config.cmake`` and ``ignition-rendering<#>-ogre-config.cmake`` in ``CMAKE_PREFIX_PATH``. That path could be ``ign-rendering-install-path\lib\cmake``, for example. | |
As``ign-rendering`` is not available on conda-forge, we need to build it from source and specify the path containing ``ignition-rendering<#>-config.cmake`` and ``ignition-rendering<#>-ogre-config.cmake`` in ``CMAKE_PREFIX_PATH``. That path could be ``ign-rendering-install-path\lib\cmake``, for example. |
I think I did that on purpose on #127 because they seemed out of place in the README. A README user had no context for generating docs or running tests... But I think that you are adding enough context in this PR. Maybe we can consider moving those to their own tutorials in the future. I think the README could be more focused on highlighting features and quick onboarding, and specific development details can be left to tutorials. Thanks for the PR. Just curious, did you try running |
Closing to retarget at Citadel. #168 |
For visibility, I tested this out by attempting to run a few examples and Qt crashed every time, for what it's worth, here is the error message in case this may be relevant later:
Not sure if this may be a local issue or if reinstalling Qt would actually work, it could also be some sort of issue with the version of Qt that |
Partially addresses gazebosim/docs#117
Moved Documentation and Testing sections from the installation tutorial back to README - looks like a mistake that they were moved before. These two sections stayed in the README for other libraries.
One of the dependencies,
libignition-rendering
, is not yet on conda-forge and needs to be installed from source.libignition-gui
is also not on conda-forge, so we don't have binary install instructions for Windows in this PR.Both libraries need to be added to conda-forge.