-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows installation; move installation in README to tutorial #146
Conversation
…DME and tutorial Signed-off-by: Mabel Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-common3 #146 +/- ##
============================================
Coverage 75.53% 75.53%
============================================
Files 69 69
Lines 9623 9623
============================================
Hits 7269 7269
Misses 2354 2354 Continue to review full report at Codecov.
|
Signed-off-by: Mabel Zhang <[email protected]>
The difference is that the ignition-cmake available in conda-forge contains a patch to fix the GTS-problem reported by @JShep1 :
So the problem is still present if ignition-cmake is compiled from source when building all the ignition projects together with colcon, but not present if ignition-cmake is installed via conda-forge. |
Signed-off-by: Mabel Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small consistency nit but LGMT otherwise
Same comment about formatting as gazebosim/gz-math#185 (comment) I'm not sure if that fixes it though. Looking at the profiler tutorial in this repo, Troubleshoot section, bullets 2 and 4 have code blocks, one with a preceding empty line and one without, both rendered incorrectly. So the empty line isn't the answer. Do you think changing from 4 spaces to 2 spaces helps??? Notably, the |
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Formatting has been fixed, given the tip in the other PR. |
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Partially addresses gazebosim/docs#117 and gazebosim/docs#14 (comment) .
Adds Windows binary and from source install instructions for Windows installation instructions per library docs#117 .
For some reason, I didn't encounter the compilation error @JShep1 mentioned here Top-level Windows installation instructions docs#96 (comment) .
My steps are slightly different, as necessitated by these per-package installation tutorials.
John built everything from source using
colcon
.I did
conda-forge
binary install forign-cmake
andign-math
, and then purecmake
.Not sure if that makes the difference or I'm missing something.
Moves installation in README to a new installation tutorial page for Consolidate Library READMEs with installation tutorials docs#14 (comment) .
TODO: The URL in README currently links to
ign-common
tutorials main page, since the installation tutorial webpage doesn't exist yet. Somebody should change the link after this PR is deployed. Trivial fix of the URL in README line 63.