Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct tds rate with lower deduction certificate #44794

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

ljain112
Copy link
Contributor

Issue:
The tax withholding rate is incorrect if tax withholding from_date doesn't match with lower deduction certificate period.
Steps to replicate:

  • Create a tax withholding category with period 1-10-2024 to 31-3-2025.
  • Create a Supplier with a tax withholding category.
  • Create a Lower Deduction Certification for the supplier,valid from 1-4-2024 and valid up to 31-3-2025.
  • Even though LDC is valid and within the period, it will not be applied due to incorrect date filters.

Solution:
Validating LDC based on inv date.

Frappe Support Issue: https://support.frappe.io/app/hd-ticket/27014

backport version-15-hotfix
backport version-14-hotfix

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 19, 2024
@ruthra-kumar ruthra-kumar self-assigned this Dec 23, 2024
@ruthra-kumar ruthra-kumar merged commit c59d3bd into frappe:develop Dec 24, 2024
13 checks passed
ruthra-kumar added a commit that referenced this pull request Dec 24, 2024
…-44794

fix: correct tds rate with lower deduction certificate (backport #44794)
ruthra-kumar added a commit that referenced this pull request Dec 24, 2024
…-44794

fix: correct tds rate with lower deduction certificate (backport #44794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants