Skip to content

Commit

Permalink
Merge pull request #44794 from ljain112/fix-ldc
Browse files Browse the repository at this point in the history
fix: correct tds rate with lower deduction certificate
  • Loading branch information
ruthra-kumar authored Dec 24, 2024
2 parents d4b21f5 + cb9c12d commit c59d3bd
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -247,14 +247,14 @@ def get_tax_row_for_tds(tax_details, tax_amount):
}


def get_lower_deduction_certificate(company, tax_details, pan_no):
def get_lower_deduction_certificate(company, posting_date, tax_details, pan_no):
ldc_name = frappe.db.get_value(
"Lower Deduction Certificate",
{
"pan_no": pan_no,
"tax_withholding_category": tax_details.tax_withholding_category,
"valid_from": (">=", tax_details.from_date),
"valid_upto": ("<=", tax_details.to_date),
"valid_from": ("<=", posting_date),
"valid_upto": (">=", posting_date),
"company": company,
},
"name",
Expand Down Expand Up @@ -302,7 +302,7 @@ def get_tax_amount(party_type, parties, inv, tax_details, posting_date, pan_no=N
tax_amount = 0

if party_type == "Supplier":
ldc = get_lower_deduction_certificate(inv.company, tax_details, pan_no)
ldc = get_lower_deduction_certificate(inv.company, posting_date, tax_details, pan_no)
if tax_deducted:
net_total = inv.tax_withholding_net_total
if ldc:
Expand Down

0 comments on commit c59d3bd

Please sign in to comment.