Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Implemented Search Feature #56

Merged
merged 20 commits into from
Aug 19, 2018
Merged

Implemented Search Feature #56

merged 20 commits into from
Aug 19, 2018

Commits on Aug 3, 2018

  1. Added Initial Search Page Implementation

    This includes debouncing user input, querying, and some style stuff.
    0xcaff committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    c6b9fa6 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2018

  1. Configuration menu
    Copy the full SHA
    75cf42d View commit details
    Browse the repository at this point in the history
  2. Removed Artists from Search Query

    They'll be added back when we figure out how to implement the artists view.
    0xcaff committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    7a4c1eb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6f4d1a9 View commit details
    Browse the repository at this point in the history
  4. Use AlbumInfo in SearchPage

    0xcaff committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    e0199e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. Initial Query Populated From Search

    There are two sources of updates for the search input.
    
    1. The user typing directly into the input. This change comes from a
    child of the state container.
    
    2. The url changing. This comes from the parent of the state container.
    
    There are a few ways to reconcile props from multiple locations, none of
    which work well.
    
    1. Use key to render a new component when the query changes. This works
    but the focus of the input is lost.
    
    2. Use componentDidUpdate. It is intended for props and causes an extra
    render.
    0xcaff committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    b177874 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    925ced9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8d84151 View commit details
    Browse the repository at this point in the history
  4. StateContainer Now Updates From Props

    Updates flow up from the input to the StateContainer and to the url.
    State flows down from the url and the state container to the
    presentational components.
    
    This is clear and simple. I think the StateContainer should be simpler.
    0xcaff committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    4bb8f97 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2018

  1. Configuration menu
    Copy the full SHA
    bdbf429 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2018

  1. Broke SearchPage into AlbumSearchResults and SongSearchResults

    They both independently handle fetching and rendering of each section of
    the search page.
    0xcaff committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    5e30452 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e889064 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b3e340f View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2018

  1. Added Sort Adjustment

    0xcaff committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    2032948 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7d4519a View commit details
    Browse the repository at this point in the history
  3. Removed TODOs

    0xcaff committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    82a85f4 View commit details
    Browse the repository at this point in the history
  4. Use Fragments in SearchQuery

    0xcaff committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    df1a292 View commit details
    Browse the repository at this point in the history
  5. Removed Unused Component

    0xcaff committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    288edf3 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2018

  1. Added Docs

    0xcaff committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    5696baa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    25096a0 View commit details
    Browse the repository at this point in the history