This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Commits on Aug 3, 2018
-
Added Initial Search Page Implementation
This includes debouncing user input, querying, and some style stuff.
Configuration menu - View commit details
-
Copy full SHA for c6b9fa6 - Browse repository at this point
Copy the full SHA c6b9fa6View commit details
Commits on Aug 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 75cf42d - Browse repository at this point
Copy the full SHA 75cf42dView commit details -
Removed Artists from Search Query
They'll be added back when we figure out how to implement the artists view.
Configuration menu - View commit details
-
Copy full SHA for 7a4c1eb - Browse repository at this point
Copy the full SHA 7a4c1ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f4d1a9 - Browse repository at this point
Copy the full SHA 6f4d1a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0199e7 - Browse repository at this point
Copy the full SHA e0199e7View commit details
Commits on Aug 7, 2018
-
Initial Query Populated From Search
There are two sources of updates for the search input. 1. The user typing directly into the input. This change comes from a child of the state container. 2. The url changing. This comes from the parent of the state container. There are a few ways to reconcile props from multiple locations, none of which work well. 1. Use key to render a new component when the query changes. This works but the focus of the input is lost. 2. Use componentDidUpdate. It is intended for props and causes an extra render.
Configuration menu - View commit details
-
Copy full SHA for b177874 - Browse repository at this point
Copy the full SHA b177874View commit details -
Configuration menu - View commit details
-
Copy full SHA for 925ced9 - Browse repository at this point
Copy the full SHA 925ced9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d84151 - Browse repository at this point
Copy the full SHA 8d84151View commit details -
StateContainer Now Updates From Props
Updates flow up from the input to the StateContainer and to the url. State flows down from the url and the state container to the presentational components. This is clear and simple. I think the StateContainer should be simpler.
Configuration menu - View commit details
-
Copy full SHA for 4bb8f97 - Browse repository at this point
Copy the full SHA 4bb8f97View commit details
Commits on Aug 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for bdbf429 - Browse repository at this point
Copy the full SHA bdbf429View commit details
Commits on Aug 13, 2018
-
Broke SearchPage into AlbumSearchResults and SongSearchResults
They both independently handle fetching and rendering of each section of the search page.
Configuration menu - View commit details
-
Copy full SHA for 5e30452 - Browse repository at this point
Copy the full SHA 5e30452View commit details -
Configuration menu - View commit details
-
Copy full SHA for e889064 - Browse repository at this point
Copy the full SHA e889064View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3e340f - Browse repository at this point
Copy the full SHA b3e340fView commit details
Commits on Aug 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 2032948 - Browse repository at this point
Copy the full SHA 2032948View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d4519a - Browse repository at this point
Copy the full SHA 7d4519aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82a85f4 - Browse repository at this point
Copy the full SHA 82a85f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for df1a292 - Browse repository at this point
Copy the full SHA df1a292View commit details -
Configuration menu - View commit details
-
Copy full SHA for 288edf3 - Browse repository at this point
Copy the full SHA 288edf3View commit details
Commits on Aug 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 5696baa - Browse repository at this point
Copy the full SHA 5696baaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25096a0 - Browse repository at this point
Copy the full SHA 25096a0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.