This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Implemented Search Feature #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes debouncing user input, querying, and some style stuff.
They'll be added back when we figure out how to implement the artists view.
There are two sources of updates for the search input. 1. The user typing directly into the input. This change comes from a child of the state container. 2. The url changing. This comes from the parent of the state container. There are a few ways to reconcile props from multiple locations, none of which work well. 1. Use key to render a new component when the query changes. This works but the focus of the input is lost. 2. Use componentDidUpdate. It is intended for props and causes an extra render.
Updates flow up from the input to the StateContainer and to the url. State flows down from the url and the state container to the presentational components. This is clear and simple. I think the StateContainer should be simpler.
They both independently handle fetching and rendering of each section of the search page.
AzureMarker
reviewed
Aug 18, 2018
| </AlbumsQuery> | ||
| ); | ||
|
|
||
| // TODO: Share Loading More Logic With AlbumsPage |
There was a problem hiding this comment.
Is this planned for this PR?
AzureMarker
suggested changes
Aug 19, 2018
| @@ -17,6 +17,9 @@ interface Props { | |||
| children: (songs: Song[]) => React.ReactNode; | |||
| } | |||
|
|
|||
| // he header for song search results. Handles the cases when `songs` is | |||
|
When something is called |
|
As for using doc comments for documentation. Good idea. It is little work for a lot of benefit. I've opened #59 to fix it. |
|
I didn't name anything |
AzureMarker
approved these changes
Aug 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the search feature for albums, and songs. Artists will be implemented when the rest of the Artist stuff is done.
Closes #12