-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(share_plus): SharePlus refactor #3404
Open
miquelbeltran
wants to merge
20
commits into
main
Choose a base branch
from
3403-share-plus-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+946
−766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2024
One last big piece missing is the Windows refactor, which I plan to do tomorrow or so. Then I'll write up a migration guide on the README.md. The API and functionality is still backwards compatible, but just getting deprecated warnings. The old The
|
miquelbeltran
changed the title
feat(share_plus): SharePlus refactor (WIP)
feat(share_plus): SharePlus refactor
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains several improvements on the share_plus package:
SharePlus
class viainstance
singleton, rather than using static methods.SharePlatform
for testing.subject
andtitle
.ShareParams
class.mailToFallbackEnabled
to disable web mailTo failback (enabled by default)downloadFallbackEnabled
is no longer a static setting but part of theShareParams
uri
is now supported on all platforms by sharing the URI as plain textNot a breaking change, since the old API is still compatible, only it has been deprecated.
But we should consider bumping the version of
share_plus
to a major release nevertheless, since the deprecation will break CI/CD lint analysis.TODO:
Related Issues
share_plus
refactor #3403EXTRA_TITLE
in share Intent on Android #3307Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).