Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(share_plus): Added excludedActivityTypes support for the iOS platform. #3376

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

StanleyCocos
Copy link
Contributor

@StanleyCocos StanleyCocos commented Dec 3, 2024

The iOS platform is missing the exclusion feature. This PR adds the platform exclusion functionality for iOS.

fix: #3377

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran
Copy link
Member

miquelbeltran commented Dec 3, 2024

Thanks for this contribution as well! We have to keep this one on hold because I plan to refactor the share() method parameters, as also discussed in #3307 (comment)

Your input on this topic would be appreciated as well.

@StanleyCocos
Copy link
Contributor Author

@miquelbeltran
Thank you for your reply.
I understand your plan now. If needed, I can still improve this PR after your plan.

@miquelbeltran
Copy link
Member

FYI, started working on the shareplus refactor, that should simplify adding this and other optional parameters: #3404

@StanleyCocos
Copy link
Contributor Author

Hi, that's great! I've been studying the code in your branch. It's really well-organized and tidy. Next, I need to add the parameter excludedActivityType for this pull request (PR) to ShareParams. After that, I'll wait for you to finish merging xx into the main branch. Once that's done, I'll synchronize my changes accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: (share_plus) Add platform exclusion functionality for iOS.
2 participants