-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add toolbar environment variables #23
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution, I will review your PR soon :) |
Hello, Thank you again for contributing to p0wny@shell. Here are some some initial review and remarks about the PR
I cherry-picked the 3 first features of the list above as they were mostly ok → it's on
I will continue reviewing the env feature itself after you rebased the PR on the new |
Thank @flozz for your review. Sorry for rules of code. Because this really is first my pull request to contribute on GitHub, so I can haven't experience for this 🗡️ Let me to resolve all this issues |
Signed-off-by: nakamuraos <[email protected]>
Updated as your comment @flozz:
|
Have a plan to update env feature better after this merged:
Besides, I always want this script as simple as possible (as a part of p0wny-shell's goals) |
This PR has the features:
1. Add toolbar environment variables: user can add, edit or remove environment variables
How to use?
;
(your command will final) after you hit enter.2. Fix key arrow up
3. Fix CSS logo
4. A little change
5. Bonus