Feature: add focus to shell input when click anywhere #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakamuraos
changed the title
nakamuraos
changed the title
flozz
requested changes
Jan 21, 2021
There was a problem hiding this comment.
Also, can you call your new function in the onload callback (replacing the eShellCmdInput.focus(); line) : https://github.com/flozz/p0wny-shell/blob/master/shell.php#L434
| function focusShellCmd() { | ||
| var selection = window.getSelection(); | ||
| if(!selection.toString()) { | ||
| document.getElementById('shell-cmd').focus(); |
There was a problem hiding this comment.
No need to call getElementById() here, there is already a eShellCmdInput variable that contains this element
There was a problem hiding this comment.
No. The changes which you mention not correct. The code in this PR will execute every click, not only onload.
<body onclick="focusShellCmd();">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When click to shell, I want my mouse will focus to command input. This PR will add a function javascript to detect onclick (check not selecting text too).