Add Attributes support and logical types #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiabasone
force-pushed
the
merge-with-flix-tech
branch
from
5420a1e to
728d9d5
Compare
mattiabasone
force-pushed
the
merge-with-flix-tech
branch
from
728d9d5 to
5c3dedc
Compare
tPl0ch
reviewed
Jan 29, 2025
| } | ||
|
|
||
| #[Test] | ||
| public function it_should_generate_records_containing_records_using_attributes(): void |
There was a problem hiding this comment.
@mattiabasone Was there a reason that you only implemented this test, and not the other tests?
There was a problem hiding this comment.
@tPl0ch No reason at all :D I've refactored a bit the test class and fixed an error, what do you think about it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.