Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
mattiabasone committed Jan 29, 2025
1 parent b4ceb67 commit 728d9d5
Show file tree
Hide file tree
Showing 19 changed files with 20 additions and 34 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,6 @@ jobs:
-
version: '8.2'
composer: --prefer-stable
-
version: '8.2'
composer: --prefer-stable
-
version: '8.3'
composer: --prefer-stable
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "mattiabasone/avro-serde-php",
"name": "flix-tech/avro-serde-php",
"description": "A library to serialize and deserialize Avro records making use of the confluent schema registry",
"keywords": [
"confluent-platform",
Expand Down
3 changes: 3 additions & 0 deletions src/Objects/Schema/Generation/AttributeReader.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ public function readPropertyAttributes(\ReflectionProperty $property): SchemaAtt
return $this->getSchemaAttributes(...$attributes);
}

/**
* @param \ReflectionAttribute<object> ...$attributes
*/
private function getSchemaAttributes(\ReflectionAttribute ...$attributes): SchemaAttributes
{
$attributes = array_map(fn ($attr) => $attr->newInstance(), $attributes);
Expand Down
2 changes: 1 addition & 1 deletion src/Objects/Schema/Generation/Attributes/AvroDoc.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
final class AvroDoc implements SchemaAttribute
{
public function __construct(
public string $value
public string $value,
) {
}

Expand Down
2 changes: 1 addition & 1 deletion src/Objects/Schema/Generation/Attributes/AvroType.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class AvroType implements SchemaAttribute

public function __construct(
Type|string $value,
SchemaAttribute ...$attributes
SchemaAttribute ...$attributes,
) {
$this->value = \is_string($value) ? $value : $value->value;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

namespace FlixTech\AvroSerializer\Test\Integrations\Symfony\Serializer;

use PHPUnit\Framework\Attributes\Test;
use Doctrine\Common\Annotations\AnnotationReader as DoctrineAnnotationReader;
use FlixTech\AvroSerializer\Integrations\Symfony\Serializer\AvroSerDeEncoder;
use FlixTech\AvroSerializer\Integrations\Symfony\Serializer\NameConverter\AvroNameConverter;
Expand Down
2 changes: 0 additions & 2 deletions test/Integrations/Symfony/Serializer/AvroSerDeEncoderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

namespace FlixTech\AvroSerializer\Test\Integrations\Symfony\Serializer;

use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\DataProvider;
use FlixTech\AvroSerializer\Integrations\Symfony\Serializer\AvroSerDeEncoder;
use FlixTech\AvroSerializer\Objects\RecordSerializer;
use FlixTech\AvroSerializer\Test\AbstractFunctionalTestCase;
Expand Down
1 change: 0 additions & 1 deletion test/Objects/DefaultRecordSerializerFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

namespace FlixTech\AvroSerializer\Test\Objects;

use PHPUnit\Framework\Attributes\Test;
use FlixTech\AvroSerializer\Objects\DefaultRecordSerializerFactory;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;
Expand Down
1 change: 0 additions & 1 deletion test/Objects/Schema/ArrayTypeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

namespace FlixTech\AvroSerializer\Test\Objects\Schema;

use PHPUnit\Framework\Attributes\Test;
use FlixTech\AvroSerializer\Objects\Schema;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;
Expand Down
1 change: 0 additions & 1 deletion test/Objects/Schema/EnumTypeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

namespace FlixTech\AvroSerializer\Test\Objects\Schema;

use PHPUnit\Framework\Attributes\Test;
use FlixTech\AvroSerializer\Objects\Schema;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;
Expand Down
1 change: 0 additions & 1 deletion test/Objects/Schema/FixedTypeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

namespace FlixTech\AvroSerializer\Test\Objects\Schema;

use PHPUnit\Framework\Attributes\Test;
use FlixTech\AvroSerializer\Objects\Schema;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;
Expand Down
16 changes: 8 additions & 8 deletions test/Objects/Schema/Generation/Fixture/RecordWithRecordType.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
*
* @SerDe\AvroName("RecordWithRecordType")
*/
#[AvroType("record")]
#[AvroName("RecordWithRecordType")]
#[AvroType('record')]
#[AvroName('RecordWithRecordType')]
class RecordWithRecordType
{
/**
Expand All @@ -29,10 +29,10 @@ class RecordWithRecordType
* @SerDe\AvroDoc("This a simple record for testing purposes")
* })
*/
#[AvroName("simpleField")]
#[AvroType("record",
#[AvroName('simpleField')]
#[AvroType('record',
new AvroTargetClass(SimpleRecord::class),
new AvroDoc("This a simple record for testing purposes")
new AvroDoc('This a simple record for testing purposes')
)]
private SimpleRecord $simpleRecord;

Expand All @@ -42,8 +42,8 @@ class RecordWithRecordType
* @SerDe\AvroType("null")
* @SerDe\AvroType("org.acme.SimpleRecord")
*/
#[AvroName("unionField")]
#[AvroType("null")]
#[AvroType("org.acme.SimpleRecord")]
#[AvroName('unionField')]
#[AvroType('null')]
#[AvroType('org.acme.SimpleRecord')]
private ?SimpleRecord $unionRecord;
}
12 changes: 6 additions & 6 deletions test/Objects/Schema/Generation/Fixture/SimpleRecord.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,29 +17,29 @@
*
* @SerDe\AvroType("record")
*/
#[AvroName("SimpleRecord")]
#[AvroNamespace("org.acme")]
#[AvroType("record")]
#[AvroName('SimpleRecord')]
#[AvroNamespace('org.acme')]
#[AvroType('record')]
class SimpleRecord
{
/**
* @SerDe\AvroType("int")
*
* @SerDe\AvroDefault(42)
*/
#[AvroType("int")]
#[AvroType('int')]
#[AvroDefault(42)]
private $intType;

/**
* @SerDe\AvroType("uuid")
*/
#[AvroType("uuid")]
#[AvroType('uuid')]
private $uuidType;

/**
* @SerDe\AvroType("timestamp-millis")
*/
#[AvroType("timestamp-millis")]
#[AvroType('timestamp-millis')]
private $timestampMillisType;
}
1 change: 0 additions & 1 deletion test/Objects/Schema/MapTypeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

namespace FlixTech\AvroSerializer\Test\Objects\Schema;

use PHPUnit\Framework\Attributes\Test;
use FlixTech\AvroSerializer\Objects\Schema;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;
Expand Down
1 change: 0 additions & 1 deletion test/Objects/Schema/RecordTypeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace FlixTech\AvroSerializer\Test\Objects\Schema;

use PHPUnit\Framework\Attributes\Test;
use FlixTech\AvroSerializer\Objects\Schema;
use FlixTech\AvroSerializer\Objects\Schema\Record\FieldOption;
use PHPUnit\Framework\Attributes\Test;
Expand Down
1 change: 0 additions & 1 deletion test/Objects/SchemaResolvers/ChainResolverTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace FlixTech\AvroSerializer\Test\Objects\SchemaResolvers;

use PHPUnit\Framework\Attributes\Test;
use FlixTech\AvroSerializer\Objects\SchemaResolverInterface;
use FlixTech\AvroSerializer\Objects\SchemaResolvers\ChainResolver;
use PHPUnit\Framework\Attributes\Test;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace FlixTech\AvroSerializer\Test\Objects\SchemaResolvers;

use PHPUnit\Framework\Attributes\Test;
use FlixTech\AvroSerializer\Objects\HasSchemaDefinitionInterface;
use FlixTech\AvroSerializer\Objects\SchemaResolvers\DefinitionInterfaceResolver;
use PHPUnit\Framework\Attributes\Test;
Expand Down
2 changes: 0 additions & 2 deletions test/Objects/SchemaResolvers/FileResolverTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

namespace FlixTech\AvroSerializer\Test\Objects\SchemaResolvers;

use PHPUnit\Framework\Attributes\Test;
use Widmogrod\Common\ValueOfInterface;
use FlixTech\AvroSerializer\Objects\SchemaResolvers\FileResolver;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\TestCase;
Expand Down
1 change: 0 additions & 1 deletion test/ProtocolTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace FlixTech\AvroSerializer\Test;

use PHPUnit\Framework\Attributes\Test;
use FlixTech\AvroSerializer\Objects\Exceptions\AvroDecodingException;
use PHPUnit\Framework\Attributes\Test;
use Widmogrod\Monad\Either\Left;
Expand Down

0 comments on commit 728d9d5

Please sign in to comment.