add logical types for attributes/annotations (#4)

flix-tech · Jan 29, 2025 · b4ceb67 · b4ceb67
1 parent f7883b0
commit b4ceb67
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 0 deletions.
diff --git a/src/Objects/Schema/Generation/TypeMapper.php b/src/Objects/Schema/Generation/TypeMapper.php
@@ -31,6 +31,13 @@ public function __construct(SchemaGenerator $generator)
             TypeName::MAP => $this->simpleType(Schema::map()),
             TypeName::ENUM => $this->simpleType(Schema::enum()),
             TypeName::FIXED => $this->simpleType(Schema::fixed()),
+            TypeName::UUID => $this->simpleType(Schema::uuid()),
+            TypeName::TIME_MICROS => $this->simpleType(Schema::timeMicros()),
+            TypeName::TIME_MILLIS => $this->simpleType(Schema::timeMillis()),
+            TypeName::TIMESTAMP_MICROS => $this->simpleType(Schema::timestampMicros()),
+            TypeName::TIMESTAMP_MILLIS => $this->simpleType(Schema::timestampMillis()),
+            TypeName::LOCAL_TIMESTAMP_MICROS => $this->simpleType(Schema::localTimestampMicros()),
+            TypeName::LOCAL_TIMESTAMP_MILLIS => $this->simpleType(Schema::localTimestampMillis()),
         ];
     }
 

diff --git a/test/Objects/Schema/Generation/Fixture/SimpleRecord.php b/test/Objects/Schema/Generation/Fixture/SimpleRecord.php
@@ -30,4 +30,16 @@ class SimpleRecord
     #[AvroType("int")]
     #[AvroDefault(42)]
     private $intType;
+
+    /**
+     * @SerDe\AvroType("uuid")
+     */
+    #[AvroType("uuid")]
+    private $uuidType;
+
+    /**
+     * @SerDe\AvroType("timestamp-millis")
+     */
+    #[AvroType("timestamp-millis")]
+    private $timestampMillisType;
 }
diff --git a/test/Objects/Schema/Generation/SchemaGeneratorTest.php b/test/Objects/Schema/Generation/SchemaGeneratorTest.php
@@ -168,6 +168,14 @@ public function it_should_generate_records_containing_records(): void
                         'intType',
                         Schema::int(),
                         Schema\Record\FieldOption::default(42)
+                    )
+                    ->field(
+                        'uuidType',
+                        Schema::uuid()
+                    )
+                    ->field(
+                        'timestampMillisType',
+                        Schema::timestampMillis()
                     ),
             )
             ->field(
@@ -198,6 +206,13 @@ public function it_should_generate_records_containing_records_using_attributes()
                         'intType',
                         Schema::int(),
                         FieldOption::default(42)
+                    )->field(
+                        'uuidType',
+                        Schema::uuid()
+                    )
+                    ->field(
+                        'timestampMillisType',
+                        Schema::timestampMillis()
                     ),
             )
             ->field(