Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documents as block #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jej2003
Copy link

@jej2003 jej2003 commented Jun 11, 2016

update to support adding documents as a batch to support BlockJoin use cases

@jej2003 jej2003 mentioned this pull request Jun 11, 2016
@romseygeek
Copy link
Collaborator

Hi, sorry for the delay in responding to this! Do you think you could add a test case to the PR illustrating how this should work?

@jej2003
Copy link
Author

jej2003 commented Aug 29, 2016

The goal would be to support BlockJoin queries once the data was indexed as a block. It's not immediately clear how to go about using a BlockJoin query in Luwak or how to go about extending it for this support. I am not sure I can provide you a test of how to do that given the current implementation without changes, thoughts?

@romseygeek
Copy link
Collaborator

Even a failing test would be useful here - just something that sketches out how you would want to use BlockJoin queries, what results you might expect, etc.

@jej2003
Copy link
Author

jej2003 commented Sep 2, 2016

Yes, I'll try to do tomorrow

On Wed, Aug 31, 2016, 5:06 AM Alan Woodward [email protected]
wrote:

Even a failing test would be useful here - just something that sketches
out how you would want to use BlockJoin queries, what results you might
expect, etc.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#88 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACvcZwp0btlopmE4tvE0heGcACFQkcn1ks5qlUQSgaJpZM4Izddm
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants