Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block join question #85

Closed
jej2003 opened this issue Apr 29, 2016 · 3 comments
Closed

Block join question #85

jej2003 opened this issue Apr 29, 2016 · 3 comments

Comments

@jej2003
Copy link

jej2003 commented Apr 29, 2016

With the addition of document batches would it be possible to slightly modify the document insertion code to add documents as a block so block join queries can be supported?

@romseygeek
Copy link
Collaborator

Hi, yes I think this would be pretty easy, just a change to MultiDocumentBatch. Do you want to raise a pull request?

@jej2003
Copy link
Author

jej2003 commented Jun 11, 2016

Looks like you were correct and this was pretty straight forward. I've opened a pull request to support this, #88

While straight forward to implement this piece, it is not immediately clear how to use Luwak to support block join queries. Would the next step be to write a new presearcher? Any pointers as to where to start would be really appreciated.

On Fri, Jun 10, 2016, 11:15 AM Alan Woodward [email protected]
wrote:

Hi, yes I think this would be pretty easy, just a change to
MultiDocumentBatch. Do you want to raise a pull request?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#85 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACvcZxUX5GhHf4W-rfFlpSMtuT-pM1haks5qKX9zgaJpZM4ISe-7
.

@romseygeek
Copy link
Collaborator

Closing as discussion has moved to the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants