Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch default ext4 inode size to 256 bytes #939

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Switch default ext4 inode size to 256 bytes #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7205c2d
build_library/disk_util: Switch default ext4 inode size to 256 bytes
jepio Jun 21, 2023
eae39e4
changelog: Add entry for ext4 inode size change
jepio Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build_library/disk_util
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ def FormatExt(part, device):
'-t', part['fs_type'],
'-b', part['fs_block_size'],
'-i', part.get('fs_bytes_per_inode', part['fs_block_size']),
'-I', part.get('fs_inode_size', 128),
'-I', part.get('fs_inode_size', 256),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun, I fixed something similar in update_engine: flatcar/update_engine@ca71b53 - we could even drop the line as it seems to be the default value but it's better to stay explicit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree about it being better to stay explicit

device,
part['fs_blocks']])

Expand Down
1 change: 1 addition & 0 deletions changelog/changes/2023-06-22-ext4-inode-size.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Changed ext4 inode size of root partition to 256 bytes. This improves compatibility with applications and is necessary for 2038 readiness ([Flatcar#1082](https://github.com/flatcar/Flatcar/issues/1082))
Loading