Switch default ext4 inode size to 256 bytes #939
Conversation
Inode sizes smaller than 256: - don't support extended metadata (nanosecond timestamp resolution) - cannot handle dates beyond 2038 - are deprecated Change the default from 128 to 256. There is no way to apply this change on a mounted filesystem so this change will only apply to new deployments. Fixes: flatcar/Flatcar#1082 Signed-off-by: Jeremi Piotrowski <[email protected]>
| @@ -403,7 +403,7 @@ def FormatExt(part, device): | |||
| '-t', part['fs_type'], | |||
| '-b', part['fs_block_size'], | |||
| '-i', part.get('fs_bytes_per_inode', part['fs_block_size']), | |||
| '-I', part.get('fs_inode_size', 128), | |||
| '-I', part.get('fs_inode_size', 256), | |||
There was a problem hiding this comment.
Fun, I fixed something similar in update_engine: flatcar/update_engine@ca71b53 - we could even drop the line as it seems to be the default value but it's better to stay explicit.
There was a problem hiding this comment.
I agree about it being better to stay explicit
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/5342991802 |
There was a problem hiding this comment.
CI is green and the change LGTM. What about a changelog entry (mentioning this change and linking to the original issue: flatcar/Flatcar#1082) ?
|
Ill add a changelog. I also started a jenkins build to manually verify that the change has taken effect, will report back. |
(In case you missed it, it is possible to download the image ( |
|
Oh - i did miss it, thanks! |
|
Pushed a changelog and validated that the inode size change worked and does the desired think (check a file with |
Signed-off-by: Jeremi Piotrowski <[email protected]>
Switch default ext4 inode size to 256 bytes
Switch default ext4 inode size to 256 bytes
Switch default ext4 inode size to 256 bytes
Switch default ext4 inode size to 256 bytes
Switch default ext4 inode size to 256 bytes
Inode sizes smaller than 256:
Change the default from 128 to 256. There is no way to apply this change on a mounted filesystem so this change will only apply to new deployments.
Fixes: flatcar/Flatcar#1082
How to use
Testing done
No testing done.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.