Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pr screenshot #75977

Conversation

Priyanshuthapliyal2005
Copy link

@Priyanshuthapliyal2005 Priyanshuthapliyal2005 commented Oct 23, 2023

Changes Made:
Updated the image old-image to new-image in the assets folder.

Reason for Changes:
The previous image needed to be change, and the updated image provides a more clear/accurate representation.

Screenshots Before:
image

Testing Done:
image
Related Issues:

Closes #75808

Checklist:

  • I have tested these changes locally.
  • I have updated the documentation (if applicable).
  • I have followed the contribution guidelines.

Request for Review:
Please review these changes and let me know if any further adjustments are needed.

Thank you!

@Esh07
Copy link
Contributor

Esh07 commented Oct 23, 2023

Thank you for your great work on this issue and for submitting your PR.

Your PR will be reviewed by the maintainer.

We appreciate your effort and contribution.

Cheers!

@Roshanjossey
Copy link
Member

Comparing the screenshots, I don't see any change for users that might cause any problems, so, I'm closing this PR.

@Priyanshuthapliyal2005, if you still strongly feel about this PR, feel free to open with more explanation about why this change is neccessary

@Priyanshuthapliyal2005
Copy link
Author

I just do the thing that mentioned in pr and said by the earlier moderator or reviewer.

@Priyanshuthapliyal2005
Copy link
Author

He just say me to change the branch master to main

@Roshanjossey
Copy link
Member

Hi @Priyanshuthapliyal2005, I understand that. In the future look for labels like help wanted or good first issue to make sure an issue is ready to be worked on. In most open source projects, anyone can create issues. That doesn't mean that the maintainers want those changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PR Screenshot on README file.
3 participants