-
-
Notifications
You must be signed in to change notification settings - Fork 77.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PR Screenshot on README file. #75808
Comments
Please update the title to descriptive. Something like Update PR Screenshot on README file. Also update description too. 🎯 Goal 💡 Possible solutions 📋 Steps to solve the problem
|
@Roshanjossey @Esh07 @Sunny-unik @satoko |
@Esh07, could you please review the changes in this pull request? Your feedback would be greatly appreciated. |
@Esh07 @Sunny-unik , could you please review the changes in this pull request #75977 ? Your feedback would be greatly appreciated. |
@Priyanshuthapliyal2005 I’ve reviewed your PR and I’ve suggested some improvements in #75977 Overall, it's good. Thanks |
@Esh07 |
I'm just a contributor on this repo, you don't need to address me as sir. You can call me Esh or ping me; it's fine. If you go to that PR and check below the comment, you will find some instructions and suggestions. |
I appreciate your guidance. I'm having trouble locating the comment with instructions on the pull request. Could you please share a screenshot or provide additional details on where I can find those instructions? |
|
|
i even did not find it @Esh07 |
Oh i see. May be I posted a wrong link. You can have a look it here https://github.com/firstcontributions/first-contributions/pull/75977/files if it is not still visible then i will convert normal comment. |
why u posting wrong link every time from many days.first check it carefully then share it with me?? |
@Sunny-unik can you review my PR?? |
I'm also new to this repo and not sure about correct solution, so wait for older maintainers. |
@Esh07 @Roshanjossey @Sunny-unik Could you please assign this issue to me? |
YES. |
|
The present README.md file has PR screenshot explaining how to create PR, that screenshot may confuse beginners.
🐞 Problem
The PR screenshot in README shows users need to send PR on the
master
branch but firstcontributions's default branch name ismain
so this screenshot may confuse beginners.🖇️ Mentioned Image
🎯 Goal
Update the screenshot with an accurate branch name. In this case, the branch should be the
main
.💡 Possible solutions
Fork the repository and create a new PR. On the creation page, take a screenshot of the current window.
📋 Steps to solve the problem
main
branch)The text was updated successfully, but these errors were encountered: