Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR Screenshot on README file. #75808

Closed
Sunny-unik opened this issue Oct 20, 2023 · 18 comments
Closed

Update PR Screenshot on README file. #75808

Sunny-unik opened this issue Oct 20, 2023 · 18 comments

Comments

@Sunny-unik
Copy link
Contributor

Sunny-unik commented Oct 20, 2023

The present README.md file has PR screenshot explaining how to create PR, that screenshot may confuse beginners.

🐞 Problem
The PR screenshot in README shows users need to send PR on the master branch but firstcontributions's default branch name is main so this screenshot may confuse beginners.

🖇️ Mentioned Image
Image Mentioned

🎯 Goal
Update the screenshot with an accurate branch name. In this case, the branch should be the main.

💡 Possible solutions
Fork the repository and create a new PR. On the creation page, take a screenshot of the current window.

📋 Steps to solve the problem

  • Create a new PR. (By default it will show main branch)
  • Take a screenshot of current window.
  • Paste the screenshot and update current screenshot in README.md file
@Esh07
Copy link
Contributor

Esh07 commented Oct 21, 2023

Please update the title to descriptive. Something like Update PR Screenshot on README file.

Also update description too.

🎯 Goal
Update the screenshot with accurate branch name. In this case, branch should be the main.

💡 Possible solutions
Fork repository and create a new PR. On creation page, take a screenshot of current window.

📋 Steps to solve the problem

  1. Create a new PR. (By default it will show main branch)
  2. Take a screenshot of current window.
  3. Paste the screenshot and update current screenshot in README.md file

@Sunny-unik Sunny-unik changed the title Need to update Readme.md screenshot Update PR Screenshot on README file. Oct 21, 2023
@Priyanshuthapliyal2005
Copy link

Priyanshuthapliyal2005 commented Oct 22, 2023

@Roshanjossey @Esh07 @Sunny-unik @satoko
can you assign this issue to me,i am working on this.

@Priyanshuthapliyal2005
Copy link

@Esh07, could you please review the changes in this pull request? Your feedback would be greatly appreciated.
Thank you

@Priyanshuthapliyal2005
Copy link

Priyanshuthapliyal2005 commented Oct 23, 2023

@Esh07 @Sunny-unik , could you please review the changes in this pull request #75977 ? Your feedback would be greatly appreciated.
Thank you

@Esh07
Copy link
Contributor

Esh07 commented Oct 24, 2023

@Priyanshuthapliyal2005 I’ve reviewed your PR and I’ve suggested some improvements in #75977

Overall, it's good.

Thanks

@Priyanshuthapliyal2005
Copy link

@Esh07
sir in #75977
you just reply this msg:
image
what improvement is needed?
in my previou pull request #75928
@Sunny-unik reply this msg:
image
i close that pr bcoz i got confused somewhere,that's why i start from the beginning again and first pr in assets repository
you can checkout that here: firstcontributions/assets#36
after that pr i use that repository updated screenshot here in this readmefile.
Thankyou

@Esh07
Copy link
Contributor

Esh07 commented Oct 25, 2023

I'm just a contributor on this repo, you don't need to address me as sir. You can call me Esh or ping me; it's fine.

If you go to that PR and check below the comment, you will find some instructions and suggestions.

@Priyanshuthapliyal2005
Copy link

I'm just a contributor on this repo, you don't need to address me as sir. You can call me Esh or ping me; it's fine.

If you go to that PR and check below the comment, you will find some instructions and suggestions.

I appreciate your guidance. I'm having trouble locating the comment with instructions on the pull request. Could you please share a screenshot or provide additional details on where I can find those instructions?

@Esh07
Copy link
Contributor

Esh07 commented Oct 25, 2023

Could you please share a screenshot or provide additional details on where I can find those instructions?

#75977 (comment)

@Priyanshuthapliyal2005
Copy link

Could you please share a screenshot or provide additional details on where I can find those instructions?

#75977 (comment)

image
image

@Priyanshuthapliyal2005
Copy link

i even did not find it @Esh07

@Esh07
Copy link
Contributor

Esh07 commented Oct 26, 2023

Oh i see. May be I posted a wrong link. You can have a look it here https://github.com/firstcontributions/first-contributions/pull/75977/files

if it is not still visible then i will convert normal comment.

@Priyanshuthapliyal2005
Copy link

Oh i see. May be I posted a wrong link. You can have a look it here https://github.com/firstcontributions/first-contributions/pull/75977/files

if it is not still visible then i will convert normal comment.

why u posting wrong link every time from many days.first check it carefully then share it with me??

@Priyanshuthapliyal2005
Copy link

@Sunny-unik can you review my PR??

@Sunny-unik
Copy link
Contributor Author

@Sunny-unik can you review my PR??

I'm also new to this repo and not sure about correct solution, so wait for older maintainers.

@ruchit-t
Copy link

@Esh07 @Roshanjossey @Sunny-unik Could you please assign this issue to me?

@ansumanswain
Copy link

YES.

@Wiendoe
Copy link

Wiendoe commented Aug 25, 2024

  • [x]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants