Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rtdb) Pass database name to sseClient to allow listening to events from Reference.listen() when using firebase emulator #845

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

aiueo-1234
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

Copy link
Contributor

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@jonathanedey jonathanedey changed the title fix firebase_admin.db.Reference.listen() don't work when using firebase emulator fix(rtdb) Pass database name to sseClient to allow listening to events from Reference.listen() when using firebase emulator Jan 13, 2025
@jonathanedey jonathanedey merged commit e5618c0 into firebase:master Jan 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebase_admin.db.Reference.listen() don't work when using firebase emulator
2 participants