Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add tests for Reference.listen() #851

Merged
merged 3 commits into from
Jan 22, 2025
Merged

chore: Add tests for Reference.listen() #851

merged 3 commits into from
Jan 22, 2025

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Jan 13, 2025 •
edited
Loading

Follow up PR for #845 with unit and integration tests.

These tests ensure that the sseClient is setup with the necessary parameters in both production and emulator mode.

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Jan 13, 2025
@jonathanedey jonathanedey changed the title chore: Add unit tests for Reference.listen() chore: Add tests for Reference.listen() Jan 20, 2025
lahirumaramba
lahirumaramba approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@jonathanedey jonathanedey merged commit e6c95e7 into master Jan 22, 2025
12 checks passed
@jonathanedey jonathanedey deleted the je-db-listen branch January 22, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees
No one assigned
Labels
release:stage Stage a release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanedey @lahirumaramba