-
Notifications
You must be signed in to change notification settings - Fork 164
refactor(snack-sdk): replace fetch ponyfill with global fetch #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd4e7d4 to
ac0322b
Compare
byCedric
approved these changes
Nov 27, 2025
Member
byCedric
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need to fix CI before merging, but it looks good overall.
byCedric
reviewed
Nov 27, 2025
b7aafe1 to
8fb3daa
Compare
8fb3daa to
486bbac
Compare
486bbac to
80bc5fd
Compare
krystofwoldrich
commented
Nov 27, 2025
f388fa8 to
9e4bb20
Compare
2f9e718 to
fee1924
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I was running into the following error when using the Snack SDK in CF Workers.
I've tracked down the issue to an old
node-fetch.How
This PR removes the current ponyfill and defaults to global fetch impl of the runtime.
Since all modern browser have a solid
fetchimplementation, I think we could use the global for web. Likely we could do the same for Expo Apps.For modern node ponyfill would also not be needed. But for other envs for example CF Workers, we need the ability to change the
fetchfunction. So I exposed a public functionsetSnackSDKFetch(fn).Test Plan