refactor: upgrade to Jest 29 for fetch support #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
reviewed
Dec 1, 2025
| react-is "^18.2.0" | ||
| use-latest-callback "^0.2.1" | ||
| use-sync-external-store "^1.2.2" | ||
|
|
Member
There was a problem hiding this comment.
This seems a little suspicious, not sure what's going on but luckily we aren't using runtime-shell. Just noting it for myself to check this out later.
byCedric
approved these changes
Dec 1, 2025
Member
byCedric
left a comment
byCedric
left a comment
There was a problem hiding this comment.
Looks good with 1 weird version rollback, likely not caused by this PR.
byCedric
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Old jest versions don't have global fetch available in the node env.
How
bump to jest 29 (one version behind latest 30)
Test Plan
ci all test should pass