Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Fix worker asset upload error not being shown #2579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kitten
Copy link
Member

@kitten kitten commented Sep 19, 2024

Why

We accidentally were hiding asset upload errors, which should be shown.

How

Remove code ignoring upload errors accidentally.

Test Plan

Manually tested

Copy link

github-actions bot commented Sep 19, 2024

Size Change: -802 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -802 B (0%)

compressed-size-action

@kitten kitten force-pushed the @kitten/fix/cli-upload-asset-errors branch from 4fee421 to 19ceb63 Compare September 19, 2024 20:14
Copy link

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.09%. Comparing base (d42cbe0) to head (19ceb63).

Files with missing lines Patch % Lines
packages/eas-cli/src/worker/upload.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2579   +/-   ##
=======================================
  Coverage   52.09%   52.09%           
=======================================
  Files         559      559           
  Lines       21101    21101           
  Branches     4315     4315           
=======================================
  Hits        10991    10991           
+ Misses       9232     9231    -1     
- Partials      878      879    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant