Skip to content

Commit

Permalink
Fix worker asset upload error not being shown
Browse files Browse the repository at this point in the history
  • Loading branch information
kitten committed Sep 19, 2024
1 parent d42cbe0 commit 19ceb63
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ This is the log of notable changes to EAS CLI and related packages.
### 🐛 Bug fixes

- Avoid malforming `app.json` with empty `.expo` object. ([#2573](https://github.com/expo/eas-cli/pull/2573) by [@byCedric](https://github.com/byCedric))
- Fix typo causing `worker:deploy` asset upload errors not to be shown properly. ([#2579](https://github.com/expo/eas-cli/pull/2579) by [@kitten](https://github.com/kitten))

### 🧹 Chores

Expand Down
10 changes: 5 additions & 5 deletions packages/eas-cli/src/worker/upload.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,13 @@ export async function* batchUploadAsync(
}
yield await Promise.race(queue);
}
} catch (error: any) {
if (typeof error !== 'object' || error.name !== 'AbortError') {
throw error;
}
} finally {

if (queue.size > 0) {
controller.abort();
}
} catch (error: any) {
if (error.name !== 'AbortError') {
throw error;
}
}
}

0 comments on commit 19ceb63

Please sign in to comment.