New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Fix wrong directional check for low is worse metrics #633

Merged

robinholzi merged 3 commits into main from robinholzi/fix/dynamic-threshold-direction-lower

Sep 12, 2024

Merged

fix!: Fix wrong directional check for low is worse metrics #633

Merge branch 'main' into robinholzi/fix/dynamic-threshold-direction-l…

Codecov / codecov/patch succeeded Sep 12, 2024 in 0s

90.00% of diff hit (target 85.61%)

View this Pull Request on Codecov

90.00% of diff hit (target 85.61%)

Annotations

Check warning on line 90 in modyn/supervisor/internal/triggers/performance/decision_policy.py

codecov / codecov/patch

modyn/supervisor/internal/triggers/performance/decision_policy.py#L90

Added line #L90 was not covered by tests

Check warning on line 161 in modyn/supervisor/internal/triggers/performancetrigger.py

codecov / codecov/patch

modyn/supervisor/internal/triggers/performancetrigger.py#L161

Added line #L161 was not covered by tests

View more details on Codecov