Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Fix wrong directional check for low is worse metrics #633

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

robinholzi
Copy link
Collaborator

@robinholzi robinholzi commented Sep 11, 2024

Changes

  • renamed Percentile > Quantile for more concise naming
  • use np.quantile for dynamic quantile thresholds
  • adapt and add more tests

Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since the test LGTM. Need to think about the details of sorting but we can mergr this already

@robinholzi robinholzi changed the title fix: Fix wrong directional check for low is worse metrics fix!: Fix wrong directional check for low is worse metrics Sep 12, 2024
@robinholzi robinholzi self-assigned this Sep 12, 2024
@robinholzi robinholzi marked this pull request as ready for review September 12, 2024 09:33
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.61%. Comparing base (9c42e0f) to head (b3cfa56).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...r/internal/triggers/performance/decision_policy.py 66.66% 1 Missing ⚠️
...supervisor/internal/triggers/performancetrigger.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files         258      258           
  Lines       11333    11334    +1     
=======================================
+ Hits         9703     9704    +1     
  Misses       1630     1630           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks (also for switching from percentile to quantile)

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi merged commit c33c384 into main Sep 12, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants