Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding messaging when external payments are provided #1425

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Hiding messaging when external payments are provided #1425

wants to merge 4 commits into from

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Jan 17, 2025 •
edited
Loading

Issues

contributes to #1419

Changes

1419

  • Use the payment method fetching when first logging in to check if the tenant uses external payment provider
  • Setting the message if it does. Leaving it blank to "hide" it and then allow us to easily add content if we want to in the future.

Tests

Manually tested

  • hit stripe and external payment tenants

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

stripe payment for tenant
image

external payment for tenant
image

@travjenkins
Making function just set all the related data
adf5571 
Adding a blank message in case we want to put something there
Updating store names to match what they're doing now
@travjenkins travjenkins mentioned this pull request Jan 17, 2025
Open
2 tasks
@travjenkins travjenkins marked this pull request as ready for review January 22, 2025 16:15
@travjenkins travjenkins requested a review from a team as a code owner January 22, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiahna-tucker kiahna-tucker Awaiting requested review from kiahna-tucker

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@travjenkins