Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scicalc: Add swipe up action #3054

Merged
merged 3 commits into from
Oct 27, 2023
Merged

scicalc: Add swipe up action #3054

merged 3 commits into from
Oct 27, 2023

Conversation

nxdefiant
Copy link
Contributor

@nxdefiant nxdefiant commented Oct 18, 2023

Swiping up has now the same effect as hitting the "<" button.

@berkenbu Hope this is ok with you. I find it easier to correct typos that quickly appear with a single swipe instead of navigating to the correct screen first.

@nxdefiant
Copy link
Contributor Author

nxdefiant commented Oct 26, 2023

To be honest having left swipe for undo, right swipe to calculate result and accordingly up/down swipe to cycle between screens would feel more natural for me. But I did want to change the original input actions.

@berkenbu
Copy link
Contributor

Original author of the calculator here:
I have this (arguably arbitrary) mental image of the 3 input screens being arranged side by side, hence the lr swipe gesture to switch between them.
That being said, I am not married to that idea, if others find your arrangement more natural I am not against changing it to that.

@gfwilliams
Copy link
Member

This PR looks good to me - as it's just adding the swipe up functionality rather than changing things - so merging now.

Although I can definitely see the reasoning behind having swipe left as delete, and right as calculate result. While arranging the screens left/right makes sense, I think most users probably expect left swipe=delete/back, and given that arranging the screens up/down instead probably is preferable.

... so I'd be up for changing it. It might also be an opportunity to use Bangle.setUI to get user input as well?

@gfwilliams gfwilliams merged commit 684f705 into espruino:master Oct 27, 2023
1 check passed
@nxdefiant
Copy link
Contributor Author

nxdefiant commented Oct 27, 2023

ok lets do it: #3061

nxdefiant added a commit to nxdefiant/BangleApps that referenced this pull request Oct 27, 2023
As discussed in espruino#3054

- Use Swipe up/down to switch between screens, left to delete, right to
calculate result
- Also use Bangle.setUI()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants