-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calendar: Add menu to jump to settings #3051
Conversation
nxdefiant
commented
Oct 16, 2023
- Add menu to fast open settings to edit holidays
- Drop "B2 Colors" setting, use theme dark indicator instead
- Display Widgets in menus
Looks good to me, but I'd be a bit concerned about removing the non-dithered colour stuff? That was put there at some point specifically because some folks complained about not being able to see the text properly against the dither pattern? |
ok, I can re-add the color option. I just thought I spare the part to reload the color after settings change and folowing the theme to choose which color to use seemed more natural to me. Also text looks fine for me on the Bangle.js2 with dark theme. |
Just so you know while testing I spotted a bug in the settings (which wouldn't open on a fresh install it seemed) so I've fixed that - but didn't bump the version of change the changelog so I think your changes should still merge in fine |
ok, I've undone the change of the ndColors removal |
Great - thanks! |