Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Add menu to jump to settings #3051

Merged
merged 11 commits into from
Oct 20, 2023
Merged

Conversation

nxdefiant
Copy link
Contributor

  • Add menu to fast open settings to edit holidays
  • Drop "B2 Colors" setting, use theme dark indicator instead
  • Display Widgets in menus

@gfwilliams
Copy link
Member

Looks good to me, but I'd be a bit concerned about removing the non-dithered colour stuff? That was put there at some point specifically because some folks complained about not being able to see the text properly against the dither pattern?

@nxdefiant
Copy link
Contributor Author

nxdefiant commented Oct 18, 2023

ok, I can re-add the color option. I just thought I spare the part to reload the color after settings change and folowing the theme to choose which color to use seemed more natural to me. Also text looks fine for me on the Bangle.js2 with dark theme.

@gfwilliams
Copy link
Member

Ok, thanks, I just tried this out though:

image

image

There's just no comparison - I can barely make anything out, and the numbers that aren't in the current month are pretty unreadable even on desktop. I think the B2 colours option needs to stay and be the default for Bangle.js 2.

@gfwilliams
Copy link
Member

Just so you know while testing I spotted a bug in the settings (which wouldn't open on a fresh install it seemed) so I've fixed that - but didn't bump the version of change the changelog so I think your changes should still merge in fine

@nxdefiant
Copy link
Contributor Author

ok, I've undone the change of the ndColors removal

@gfwilliams
Copy link
Member

Great - thanks!

@gfwilliams gfwilliams marked this pull request as ready for review October 20, 2023 08:03
@gfwilliams gfwilliams merged commit 6b3cc13 into espruino:master Oct 20, 2023
1 check passed
@nxdefiant nxdefiant deleted the calendar branch February 11, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants