Get rid of redundant geoms_ in world.hpp#199
Open
mikel-zhobro wants to merge 1 commit intoerwincoumans:masterfrom
Open
Get rid of redundant geoms_ in world.hpp#199mikel-zhobro wants to merge 1 commit intoerwincoumans:masterfrom
geoms_ in world.hpp#199mikel-zhobro wants to merge 1 commit intoerwincoumans:masterfrom
Conversation
mikel-zhobro
changed the title
geoms_ in world.hppgeoms_ in world.hpp
mikel-zhobro
force-pushed
the
patch-1
branch
2 times, most recently
from
241db2d to
a397205
Compare
mikel-zhobro
changed the title
geoms_ in world.hppgeoms_ in world.hpp
Author
|
Should be ready to merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like
std::vector<Geometry*> geoms_;andsize_t num_geoms() const { return geoms_.size(); }inworld.hppare not used anywhere.