Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR addresses a linting issue and standardizes error handling for latent model prior checks.

Changes:

  • Refactoring: Split a long comment in tests/testthat/test-prior-latent-model.R to comply with the 80-character line length limit.
  • Enhancement: Updated R/prior.R to use cli::cli_abort() and cli::cli_warn() in the .check_latent_priors helper function. This replaces base R stop() and warning() calls, aligning with the project's use of the cli package for user interaction.

The changes ensure that the latent model prior validation is both syntactically correct (passing linter checks) and stylistically consistent (using cli).


PR created automatically by Jules for task 9802271797329737346 started by @seabbs

Refactor `tests/testthat/test-prior-latent-model.R` to split a long comment line, resolving a linting warning.
Update `.check_latent_priors` in `R/prior.R` to use `cli::cli_abort` and `cli::cli_warn` instead of `stop` and `warning`, ensuring consistent error handling and messaging across the package.
This addresses the requirement to check for non-uniform priors in latent models while adhering to package standards.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs marked this pull request as ready for review January 13, 2026 16:02
@seabbs seabbs enabled auto-merge (squash) January 13, 2026 16:02
@seabbs seabbs disabled auto-merge January 13, 2026 16:35
@seabbs seabbs merged commit 1aea958 into main Jan 13, 2026
9 of 10 checks passed
@seabbs seabbs deleted the latent-model-prior-check-3051378266831792981-9802271797329737346 branch January 13, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a warning if non-uniform events or non IID primary events are used in the latent model

1 participant