Add check for non-uniform priors in latent model #576
Conversation
Adds validation for `pwindow_raw` and `swindow_raw` priors in `epidist_latent_model`. Errors if `swindow_raw` prior is not `uniform(0, 1)`, and warns if `pwindow_raw` prior is not `uniform(0, 1)`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
=======================================
Coverage ? 95.79%
=======================================
Files ? 17
Lines ? 1046
Branches ? 0
=======================================
Hits ? 1002
Misses ? 44
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds validation for `pwindow_raw` and `swindow_raw` priors in `epidist_latent_model`. Errors if `swindow_raw` prior is not `uniform(0, 1)`, and warns if `pwindow_raw` prior is not `uniform(0, 1)`. Includes refactored validation logic to avoid code duplication and fixes linting issues.
|
Closing in favour of #580 |
1 participant
Implemented checks in
epidist_priorvia.check_latent_priorshelper function to enforce or warn about non-uniform priors on latent model window parameters, as requested in issue #478. Added a unit test to verify this behavior.PR created automatically by Jules for task 3051378266831792981 started by @seabbs