Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
getSharedTooltip,
isDialAiEntityModel,
} from '@/src/utils/app/application';
import { doesModelAllowTemperature } from '@/src/utils/app/models';
import { isEntityIdPublic } from '@/src/utils/app/publications';
import { isToolsetEntityModel } from '@/src/utils/app/toolsets';

Expand Down Expand Up @@ -135,7 +136,7 @@ export const QuickApp2Form = () => {

const showTemperatureSlider = useMemo(() => {
const selectedModel = modelsMap[modelId];
return selectedModel?.features?.temperature !== false;
return selectedModel ? doesModelAllowTemperature(selectedModel) : true;
}, [modelId, modelsMap]);

const isSharedWithMe = !!appDetails?.sharedWithMe;
Expand Down
16 changes: 13 additions & 3 deletions apps/chat/src/components/AppsEditor/Settings/form.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
import { BucketService } from '@/src/utils/app/data/bucket-service';
import { DefaultsService } from '@/src/utils/app/data/defaults-service';
import { isToolsetId } from '@/src/utils/app/id';
import { doesModelAllowTemperature } from '@/src/utils/app/models';
import { splitEntityId } from '@/src/utils/app/shared-utils';
import { ApiUtils } from '@/src/utils/server/api';

Expand Down Expand Up @@ -44,7 +45,10 @@ import {
FEATURES_ENDPOINTS_DEFAULT_VALUES,
FEATURES_ENDPOINTS_NAMES,
} from '@/src/constants/applications';
import { DEFAULT_TEMPERATURE } from '@/src/constants/default-ui-settings';
import {
DEFAULT_TEMPERATURE,
FALLBACK_TEMPERATURE,
} from '@/src/constants/default-ui-settings';
import {
DEFAULT_QUICK_APPS_MODEL,
DialDeploymentToolsetToolTypes,
Expand Down Expand Up @@ -494,14 +498,20 @@ export const getQuickAppData2 = (
{ dialDeploymentsToolsets: [], dialMCPToolsets: [] },
);

const model = modelsMap[formData.model];
const temperatureToUse =
model && doesModelAllowTemperature(model)
? formData.temperature
: FALLBACK_TEMPERATURE;

return {
...getGeneralApplicationData(formData),
applicationProperties: {
orchestrator: {
deployment: {
name: modelsMap[formData.model]?.id ?? formData.model,
name: model?.id ?? formData.model,
parameters: {
temperature: formData.temperature,
temperature: temperatureToUse,
},
},
system_prompt: {
Expand Down
16 changes: 13 additions & 3 deletions apps/chat/src/components/AppsEditor/form.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { BucketService } from '@/src/utils/app/data/bucket-service';
import { DefaultsService } from '@/src/utils/app/data/defaults-service';
import { getNextDefaultName } from '@/src/utils/app/folders';
import { isApplicationId, isToolsetId } from '@/src/utils/app/id';
import { doesModelAllowTemperature } from '@/src/utils/app/models';
import { splitEntityId } from '@/src/utils/app/shared-utils';
import { ApiUtils, parseEntityApiKey } from '@/src/utils/server/api';

Expand Down Expand Up @@ -44,6 +45,7 @@ import {
import {
DEFAULT_APPLICATION_NAME,
DEFAULT_TEMPERATURE,
FALLBACK_TEMPERATURE,
} from '@/src/constants/default-ui-settings';
import { DEFAULT_EXTERNAL_APPS_SCHEMA_ID } from '@/src/constants/external-apps';
import { formErrors } from '@/src/constants/form-errors';
Expand Down Expand Up @@ -700,7 +702,14 @@ export const getApplicationPayload = ({
document_relative_url: data.documentRelativeUrl,
},
};
case AppsEditorSchemaTypes.QuickApp2:

case AppsEditorSchemaTypes.QuickApp2: {
const model = allEntitiesMap[data.model];
const temperatureToUse =
model && isDialAiEntityModel(model) && doesModelAllowTemperature(model)
? data.temperature
: FALLBACK_TEMPERATURE;

return {
...generalData,
inputAttachmentTypes: data.inputAttachmentTypes,
Expand All @@ -713,9 +722,9 @@ export const getApplicationPayload = ({
applicationProperties: {
orchestrator: {
deployment: {
name: allEntitiesMap[data.model]?.id ?? data.model,
name: model?.id ?? data.model,
parameters: {
temperature: data.temperature,
temperature: temperatureToUse,
},
},
system_prompt: {
Expand All @@ -732,6 +741,7 @@ export const getApplicationPayload = ({
tool_sets: getQuickApp2Toolsets({ data, allEntitiesMap }),
},
};
}
case AppsEditorSchemaTypes.CustomApp:
default:
return {
Expand Down
Loading