Regex support for --secret-type #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaffitt
previously requested changes
May 16, 2024
|
Hey, what should I follow-up on? |
|
Let's try to revive this PR. I repaired the read errors metric. |
|
Any updates on when this could be merged/released? |
|
Could we proceed forward with this change? Our team also eagers for this feature as it is impossible for us to rely on a static list of secret keys. |
|
Hi @Nuckal777, sorry for the delay. With the latest changes it looks good to me. If you can rebase the branch to resolve conflicts I will merge it. And it would be awesome if you could implement the idea described here also. |
Nuckal777
force-pushed
the
secret-type-regex
branch
from
242bdf0 to
cf57f31
Compare
|
Here you go. Because we have go1.23, we can avoid the callback stuff by using iterators. 🎉 |
npdgm
approved these changes
Dec 16, 2024
|
🎉 This PR is included in version 3.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is an implementation for 242, because #243 seems a bit inactive. There are two notable changes: