regex support for flag --secret-type:<type>:<regex> #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaffitt
requested changes
Mar 22, 2024
|
|
||
| func getMatchingKeys(secretKeyValues map[string][]byte, pattern string) ([]string, error) { | ||
| keys := make([]string, 0, len(secretKeyValues)) | ||
| regex, err := regexp.Compile(pattern) |
There was a problem hiding this comment.
Rather than compiling the regex on the fly, you should compile it just after flag and argument parsing, and store them as regexes in Exporter.KubeSecretTypes in order to produce the error as soon as possible and treat it as argument parsing error. The exporter should not succeed to start if arguments are malformed.
| continue | ||
| } | ||
| for _, kubeSecretKey := range kubeSecretKeys { | ||
|
|
There was a problem hiding this comment.
In a cosmetic standpoint, this empty line could be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regex support for flag --secret-type::
For eg:
--secret-type:kubernetes.io/tls:..tls
--secret-type:Opaque:..pem